This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add e2e test helpers #666
Merged
Add e2e test helpers #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper package provides a type Command with attributes about ignite execution and methods to execute ignite commands with error checks. This simplifies a lot of the duplicate code in the e2e tests and provides reusable code to make e2e tests less verbose. This Command can be used to run commands for ignite and ignited.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces some e2e test helpers to make it easier to write e2e tests.
Package
github.com/weaveworks/ignite/e2e/util/igniteprovides typeIgnitewith functional options to set the properties of ignite operations. There will be a similar package forignitedin the future to help write ignited e2e tests.All the repeated error handling is handled by the test helpers, making the tests less verbose.
Updates all the existing e2e tests to use the test helpers.